Fix real cause of VPS authentik's DB timeout loop + repo secrets cleanup

Root cause of the 'PostgreSQL connection failed, retrying... (connection
timeout expired)' loop that survived every earlier fix (streaming
replication, the password sync, the port fix, the CoreDNS override):
authentik's Helm values had TWO sources for AUTHENTIK_POSTGRESQL__HOST/
PORT - an explicit uppercase env: override (pointed at the floating
pg-authentik.ha.huskypup.net:61432) AND a chart-generated envFrom
secretRef (pg-authentik-app, prefix: AUTHENTIK_POSTGRESQL__) whose keys
are lowercase (host, port, ...), producing a SEPARATE
AUTHENTIK_POSTGRESQL__host/port pair pointing at the old local
pg-authentik-rw:5432. Kubernetes treats these as two unrelated env vars
(case-sensitive), but authentik's own generic AUTHENTIK_*-prefixed
env-var scanner apparently doesn't, and was resolving to the lowercase
(stale, local) values regardless of the explicit override - confirmed
live by dumping the pod's actual env: both HOST and host were present
with different values. Removed the now-fully-redundant envFrom entry
(every key it provided is already explicitly set via valueFrom).

Also: user correctly pointed out plaintext secrets don't belong in the
repo. Audited for the same class of issue as the already-fixed Cloudflare
token (infrastructure/cert-manager/manifests/secret-cf-token.yaml):
- infrastructure/external-dns/manifests/secret-external-dns-unifi.yaml
  had a live UniFi API key in plaintext - moved to Vault+ExternalSecret,
  same pattern as the Cloudflare token fix. The key itself is still the
  original (now Vault-stored) value - rotating it requires the UniFi web
  UI (no self-service API), noted in the file as a separate pending step.
- infrastructure/vps-eso/manifests/clustersecretstore.yaml had the
  AppRole's roleId inline (added this session) - moved to roleRef,
  sourced from the same Secret as secretId, consistent with 'nothing
  sensitive in git' regardless of how sensitive one field is alone.

NOT touched, flagged separately for the user: infrastructure/authentik/
*-blueprint.yaml (vault, gitlab, n8n, nextcloud, rancher, grafana, argocd,
guacamole) all have live-looking high-entropy client_secret values
hardcoded in plaintext - same class of issue but much larger blast radius
(8 apps' SSO), needs its own coordinated rotation, not bundled into this
commit.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

infrastructure/authentik/values.yaml

@@ -13,10 +13,23 @@ global:
     # First secret: Authentik-specific settings (AUTHENTIK_SECRET_KEY)
     - secretRef:
         name: authentik
-    # Second secret: Database credentials from CNPG
+    # The second secretRef (pg-authentik-app, prefix: AUTHENTIK_POSTGRESQL__)
-    - secretRef:
+    # that used to live here is GONE - found live 2026-08-20 that it was
-        name: pg-authentik-app
+    # actively breaking things, not just redundant. That prefix mechanism
-      prefix: AUTHENTIK_POSTGRESQL__
+    # copies the raw secret's lowercase keys (host, port, dbname, username,
+    # password) into lowercase-suffixed env vars (AUTHENTIK_POSTGRESQL__host,
+    # etc.) - env var names are case-sensitive to Kubernetes, but authentik's
+    # own generic AUTHENTIK_*-prefixed env-var scanner is NOT, and it was
+    # picking up the lowercase AUTHENTIK_POSTGRESQL__host=pg-authentik-rw
+    # instead of the explicit uppercase AUTHENTIK_POSTGRESQL__HOST override
+    # below - silently connecting to the local CNPG service on port 5432
+    # the whole time regardless of what HOST/PORT were explicitly set to,
+    # surfacing as an unexplained "connection timeout expired" loop (the
+    # local hostname resolves fine in-cluster but on the VPS the request
+    # apparently doesn't complete - never fully root-caused, just confirmed
+    # dropping this duplicate source fixes it). Every key that secretRef
+    # used to provide (dbname/username/password) is already explicitly set
+    # via valueFrom below, so nothing is lost by removing it.
   env:
     # Configure external URL for proper OIDC discovery responses
     - name: AUTHENTIK_URL

infrastructure/external-dns/manifests/secret-external-dns-unifi.yaml

@@ -1,8 +1,33 @@
 ---
-apiVersion: v1
+# Was a plain Secret with a live UniFi API key committed in plaintext -
-kind: Secret
+# found and fixed 2026-08-20 (same class of issue as the Cloudflare token
+# in infrastructure/cert-manager/manifests/secret-cf-token.yaml, which was
+# already rotated to this pattern - this one was missed at the time).
+# Moved to Vault+ExternalSecret, matching that precedent.
+#
+# The value in Vault right now (secret/unifi-api-key) is still the
+# ORIGINAL key that was exposed in git history - rotating it (Settings ->
+# Admins -> API Keys on the UniFi controller at https://172.28.110.1, no
+# self-service API for this) is a separate, still-pending step. Once
+# rotated:
+#   vault kv put secret/unifi-api-key api-key=<new key>
+# ESO picks it up automatically (refreshInterval below), no restart
+# needed on external-dns's side.
+apiVersion: external-secrets.io/v1
+kind: ExternalSecret
 metadata:
   name: external-dns-unifi-secret
   namespace: external-dns
-stringData:
+spec:
-  api-key: 3Qha5hupHsCkkFyQb8z-T2kh-BasIGSH
+  refreshInterval: 1h
+  secretStoreRef:
+    kind: ClusterSecretStore
+    name: vault-backend
+  target:
+    name: external-dns-unifi-secret
+    creationPolicy: Owner
+  data:
+    - secretKey: api-key
+      remoteRef:
+        key: unifi-api-key
+        property: api-key

infrastructure/vps-eso/manifests/clustersecretstore.yaml

@@ -57,13 +57,14 @@
 #   vault write -f auth/approle/role/vps-eso/secret-id  # -> secret_id
 #
 # vault-approle-creds is a plain Secret created manually on the VPS
-# (kubectl, not git - same reasoning as every other VPS secret):
+# (kubectl, not git - same reasoning as every other VPS secret, and
+# consistent regardless of "how sensitive" a given field is on its own -
+# role_id and secret_id both live in the same Secret, neither in git):
 #   kubectl -n external-secrets create secret generic vault-approle-creds \
 #     --from-literal=role_id=<from role-id above> \
 #     --from-literal=secret_id=<from secret-id above>
 # Rotate the secret_id periodically by writing a new one and patching this
-# Secret - role_id is stable and not sensitive on its own (useless without
+# Secret.
-# a valid secret_id).
 apiVersion: external-secrets.io/v1
 kind: ClusterSecretStore
 metadata:
@@ -77,7 +78,10 @@ spec:
       auth:
         appRole:
           path: approle
-          roleId: ecaf2eda-d922-f7cf-1143-690bbbb4d8ea # not sensitive alone, see note above
+          roleRef:
+            name: vault-approle-creds
+            namespace: external-secrets
+            key: role_id
           secretRef:
             name: vault-approle-creds
             namespace: external-secrets

infrastructure/vps-standby/authentik/values.yaml

@@ -34,9 +34,12 @@ global:
   envFrom:
     - secretRef:
         name: authentik
-    - secretRef:
+    # The pg-authentik-app secretRef that used to live here is GONE - see
-        name: pg-authentik-app
+    # the matching comment in infrastructure/authentik/values.yaml (home's
-      prefix: AUTHENTIK_POSTGRESQL__
+    # copy of this same block) for why: its lowercase-suffixed env vars
+    # (AUTHENTIK_POSTGRESQL__host etc.) were silently winning over the
+    # explicit uppercase HOST/PORT overrides below, connecting straight to
+    # the local CNPG service the whole time regardless of what was set.
   env:
     - name: AUTHENTIK_URL
       value: "https://auth.vps.huskypup.net"